jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
450 stars 26 forks source link

Properties window cropped on scaled display #228

Open PleasantSounds opened 2 years ago

PleasantSounds commented 2 years ago

W10, fb2k 2.0 64-bit beta 13, OpenLyrics 1.3 Using a 4k display with font scaling 125%. The Properties window appears to have the contents scaled as expected, but as the Properties dialog is not resizeable, part of the contents is chopped off.

Steps to reproduce

  1. Set Windows font scaling to 125% (or anything higher than 100%)
  2. Open foobar Properties
  3. Navigate to the OpenLyrics tab

Expected behavior

Either disable font scaling (as many other properties dialogs do) or make the dialog content scrollable. image

jacquesh commented 1 year ago

Apparently any window created with CreateWindow needs to have it's items manually repositioned as documented by Microsoft, here.

On the other hand, apparently anything created with DialogBox* will be scaled automatically (for example see the wcap code here and here).