jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
403 stars 24 forks source link

[Fixed]v2: Not reading lyrics in mp3,opus,m4a works for flac #229

Closed Rexadev closed 1 year ago

Rexadev commented 1 year ago

F2K v2Beta14 OpenLyics 1.4

image image

F2K v1.6.14 OpenLyics 1.4

image

It is also tries to update the lyrics to "." image

Steps to reproduce

1. 2. 3.

Expected behavior

Versions

Additional information

Can't read SYNCEDLYRICS or LYRICS (unsynced)

jacquesh commented 1 year ago

Pasting the template does not serve any purpose if you don't fill in any details. A sequence of screenshots is not a bug report. Please include a clear & concise description of the problem in future rather than making me trawl through your screenshots to try and figure out on what you're referring to in the title.

This could be an fb2k issue. I don't believe tag-reading code was changed recently in openlyrics. Although the search also provides multiple metadata results, can you confirm that both are invalid in the fb2k-v2-beta case?

What do you mean by "Can't read SYNCEDLYRICS or LYRICS (unsynced)"? Can you provide debug console output showing it trying and failing to read those tags? What if you set one of those as the destination for saving lyrics and then try make an edit, does the console show anything of note in that case?

Rexadev commented 1 year ago

New observation for some mp3 s it works

Although the search also provides multiple metadata results, can you confirm that both are invalid in the fb2k-v2-beta case?

image

What do you mean by "Can't read SYNCEDLYRICS or LYRICS (unsynced)"?

RE: foo_openlyrics shows . instead of lyrics

Can you provide debug console output showing it trying and failing to read those tags?

Opening track for playback: "\Antarctica.m4a" Opening track for playback: "\3 Doors Down - Here Without You.mp3"

What if you set one of those as the destination for saving lyrics and then try make an edit, does the console show anything of note in that case?

Explain

jacquesh commented 1 year ago

Quite by accident, I managed to reproduce this today while looking into an unrelated issue. I've found the cause and and it should be fixed in the next release :)