search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
450 stars 26 forks source link

Lyrics Doesn't Display Properly #232

Closed christantoan closed 1 year ago

christantoan commented 1 year ago

Hello,

I'm planning to migrate from MiniLyrics and foo_uie_lyrics3 to OpenLyrics however I found out that none of my lyrics files are decoded correctly (jumbled text).

Left is OpenLyrics, middle is foo_uie_lyrics3, and right is MiniLyrics: image This is what's shown on Lyrics Editor window: image

Steps to reproduce

  1. Play a music file with the lyric file located in the same folder named %filename%.lrc

Expected behavior

The lyrics of the song from the lyrics file are displayed with highlights at the right vocal.

Versions

Additional information

Log file: log.log Example lyrics file: 8. Death Stranding.zip

Hope this can be fixed. Thank you.

christantoan commented 1 year ago

Another type(?) of display issue but this time foo_uie_lyrics3 also fails to display the lyrics correctly while MiniLyrics does. image

Logs: log.log Lyrics file: 1. Komatsu Mikako - Owaranai Melody wo Utaidashimashita.zip

jacquesh commented 1 year ago

Yeah that's a bug in the code for reading in lyrics. The Death Stranding file you gave is stored as UTF-16 and openlyrics doesn't recognise that correctly when it loads (because it hits a null byte and stops reading the string, for future-me or anybody else who might be interested).

I'll try get this fixed for the next version, but as a temporary workaround, if you could convert that to being stored as UTF-8 instead (some text editors allow you to set the encoding when you save), that should fix it for these lyrics.

christantoan commented 1 year ago

if you could convert that to being stored as UTF-8 instead (some text editors allow you to set the encoding when you save), that should fix it for these lyrics.

Thanks! It works!

Any ideas for my second post?

jacquesh commented 1 year ago

Oh woops, I didn't realise that was a completely different issue. That's the topic of #233

christantoan commented 1 year ago

Oh woops, I didn't realise that was a completely different issue. That's the topic of #233

Ok. Sorry for reporting a different issue in one report :(, I didn't realize also that there's a topic of it already.