jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
403 stars 24 forks source link

[Added][Feature] AlbumArt Background #236

Closed Rexadev closed 1 year ago

Rexadev commented 1 year ago

To back lyrics read more beautiful.

No

Component has to detect album cover color and choose a appropriate text color. Album Cover may have Dark and Light Colors.

jacquesh commented 1 year ago

This would be an extension of #80 to add blurring and adaptive text colour

jacquesh commented 11 months ago

@jacquesh was the code I posted helpfull

I confess, I've kinda stopped reading the snippets of code you post because all the ones that I did read didn't really make sense (for openlyrics, or even in general in some cases) and were often very incomplete. The bottleneck for implementing features/requests is usually not knowing how to implement it, it's having the time to implement it, test it, maintain it, make sure it fits into the rest of the infrastructure that openlyrics has setup internally, making sure it works across all the use-cases it needs to support, etcetc. I think I did also ask you in the past to please stop posting snippets in comments on issues (where they're difficult to consume at best) and instead put together a proper pull request if you want to contribute code.

I also need to setup contributor guidelines though to help manage the extra complexity that comes with accepting code from others, I've been meaning to do that for a while...for example I'd like to require that commits be signed, but I need to both document that, and make sure that my own commits are signed properly first.