Mark as instrumental "此歌曲为没有填词的纯音乐，请您欣赏"

[aaronliu0130]

Chinese lyric sources with this message "[00:00:00]此歌曲为没有填词的纯音乐，请您欣赏" mean that the thing has no lyrics. OpenLyrics should treat them as such. There's also "纯音乐，请欣赏"

[jacquesh]

Right-click -> Auto-edit -> Mark as instrumental

I'm not making automated decisions that modify user data on the basis of the particular text retrieved in lyrics. That's too error prone.

I might consider making this user-configurable (so you can decide what you want to be considered instrumental automatically), but that's a larger topic. I expect genre to be a good first approximation for this too, so I'm going to say this falls under the umbrella of #202

[aaronliu0130]

How is it error prone? This exact text is only present in instrumentals.

[aaronliu0130]

@jacquesh Maybe you could narrow the criteria to add that this is the only line?

[jacquesh]

I'm not hard-coding a comparison of retrieved lyric data (which could be literally any text data) with some arbitrary string. There are several reasons not to do that, but one is that if the text were to change slightly (which could easily happen, they add a space, put an extra newline in there somewhere, remove the comma, etc) then this matching would break out of the blue.

As I say, I'd consider adding something configurable for it but if I can, I'd rather get 80% of the way there with some other lower-variance piece of data like genre and then the remaining 20% can be covered by manual edits.

[aaronliu0130]

The lyric is already there. They don't have some sort of special case for instrumentals, it's just a template lyrics file. Existing ones will stay the same, and if such a change happens only new matchings would break, which isn't that horrible.

[aaronliu0130]

Hi @jacquesh , the message still hasn't changed. Could this be implemented?