search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
403 stars 24 forks source link

Bug - Crash on Startup - Foobar 2.0 Beta and OpenLyrics 1.5 #250

Closed Matte0Cal0 closed 1 year ago

Matte0Cal0 commented 1 year ago

Steps to reproduce

  1. Update to OpenLyrics 1.5 a few days ago
  2. Enjoy the new version as it's working perfectly
  3. Startup foobar a few days later and it crashes on startup

Expected behavior

Foobar Crashes on startup instead of working flawlessly

Versions

Foobar 2.0 Beta 31, rolling back to 30 didn't fix the problem OpenLyrics 1.5

Additional information

OpenLyrics 1.5 used to work until I wanted to use Foobar a few days later. Opening Foobar would make it crash to startup less than a second after being opened, and crash logs would Indicate an Illegal Operation on the Kernel. failure_00000026.txt

Due to the recent update, I started identifying from the way down as OpenLyrics was my instance's newer possible point of failure. I also noticed that an OpenLyrics zip was present in my component-updates. This made me want to rewind to 1.4 to see if the problem disappeared, which actually fixed the issue. Trying to update back to 1.5 through the component menu caused Foobar to crash on startup again unless I deleted the possibly broken zip file.

My instance is now fixed, but I wanted to share my problem with you or others who could meet the same issue.

Matte0Cal0

jacquesh commented 1 year ago

Thanks for reporting! I'm not sure I understand, so to clarify:

  1. You updated to openlyrics 1.5, it worked.
  2. A few days later it started crashing on startup
  3. Reverting to openlyrics 1.4 fixed the crash but going forward to 1.5 caused it crash again
  4. You finally got it working on 1.5 by deleting the openlyrics zip in component-updates.

Is that all correct? component-updates is managed entirely by fb2k itself as part of the built-in component update flow. openlyrics itself never interacts with that folder or anything inside it. I wonder if it somehow got an incomplete (or otherwise corrupted) update zip?

The only other thing I can think of that might make it suddenly start crashing is if the metrics prompt (added in 1.5) was causing an issue (since that will trigger on startup if its been at least 7 days since you updated to 1.5), but I don't see anything obvious in the error log that suggests this is the case and that wouldn't explain why deleting the component-update zip fixed it. Does fb2k create crash dumps (*.dmp files) next to those error logs? If it does, those tend to be very useful debugging tools as well.

Matte0Cal0 commented 1 year ago

Exactly, this is on point. I can confirm I was indeed running 1.5 as I had the Editor in dark mode.

I wanted to send the .dmp on the first post but GitHub doesn't allow me to do so. I uploaded it on GDrive as an alternative. I would suppose the zip got indeed corrupted, as updating the component without deleting such zip beforehand would crash before fb2k could even prompt the option to restart to finish the install.

Here is the link, https://drive.google.com/file/d/18lqSiCmM-nR_8RRN9u5HT88mhFrDhYyy/view?usp=sharing

Matte0Cal0

MikusR commented 1 year ago

Just to add. Also started getting crashes this morning. Deleting zip in updates folder did not help. Only downgrading to 1.4 did.

snowbie commented 1 year ago

Deleting the configuration file fixed it for me, but you lose your settings obviously. You can keep the config file and downgrade to 1.4. Just tried it and everything seems to be fine.

cnieuweboer commented 1 year ago

I had a crash on startup too. Deleting the config file fixed it. The crashy config file: foo_openlyrics.dll.cfg.zip

snowbie commented 1 year ago

May have been fixed in latest beta https://wiki.hydrogenaud.io/index.php?title=Foobar2000:Version_2.0_Beta_Change_Log

Matte0Cal0 commented 1 year ago

Resolved a disagreement with foo_openlyrics resulting in startup crashing.

Says it clearly. From what I could identify from my crashlogs was a misbehaving bugcheck, perhaps a specific handshake between Openlyrics and fb2k wasn't working properly.

jacquesh commented 1 year ago

Ah. Sorry about this everyone. It is indeed an openlyrics crash caused by the metrics prompt trying to do something it shouldn't have (which, I'll be honest, is disappointing because I did specifically try to prevent that from causing any user-visible errors and it also means that it won't collect any data from the people whose fb2k crashes).

The reason deleting your config file "fixes" the problem is just that it restarts the 7-day countdown before prompting for metrics. If you're on fb2k v2 then for now I'd suggest either reverting openlyrics to v1.4 or updating for fb2k to the latest version (which, as snowbie pointed out, should have at least prevented the crash, although I've not had a chance to test it myself yet so I can't confirm personally).

While I do specifically try to test new versions before releasing them to you all, this one got through mostly because I'm not yet using the fb2k v2 beta and in v1 it doesn't crash. I'll try to at least give new versions a whirl on a recent v2 beta before release next time! I will put together a v1.6 release by the end of the week (but probably not before the end of Friday, realistically).

jacquesh commented 1 year ago

Ok nevermind the weekend, I've just put out v1.6 that contains only this bugfix. Please do tell all your friends to update to v1.6 :)