search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
432 stars 24 forks source link

Add Feature to Change Offset #252

Closed ngs428 closed 1 year ago

ngs428 commented 1 year ago

In LSP3 V0.5 you can right click on a loaded lyric and select "Adjust Offset". Adjust as needed and hit save, I don't see this feature in OpenLyrics. I do like that you can apply the offset to the timestamps, that is a great help! But being able to determine the offset in OpenLyrics would be great!

Adjust Offset Dialog Box Adjust Offset Dialog Box

jacquesh commented 1 year ago

Is there any situation in which you know the exact offset (in milliseconds)?

You can already adjust the offset using the "Sync line using 'offset' tag in the lyric editor which I expect is a much more useful interface than requiring you to specify a number of milliseconds (although technically you can already do that by manually adding an [offset:<number of milliseconds>] tag to the top of your synced lyrics).

ngs428 commented 1 year ago

The first step is to find the offset. In LSP3 you start the song and then bring up that dialog box. You then increase or decrease the offset and watch how the lyrics are then synched as the song plays. Once you have the offset it is saved to the tag.

Then I typically use your tool to adjust all the time stamps by the offset. I like this part about yours, but you need to find the offset first to use it. So how I described in the first paragraph is how you find it.

From: Jacques Heunis @.> Sent: Saturday, April 15, 2023 8:20 AM To: jacquesh/foo_openlyrics @.> Cc: ngs428 @.>; Author @.> Subject: Re: [jacquesh/foo_openlyrics] Add Feature to Change Offset (Issue #252)

Is there any situation in which you know the exact offset (in milliseconds)?

You can already adjust the offset using the "Sync line using 'offset' tag in the lyric editor which I expect is a much more useful interface than requiring you to specify a number of milliseconds (although technically you can already do that by manually adding an [offset:] tag to the top of your synced lyrics).

— Reply to this email directly, view it on GitHubhttps://github.com/jacquesh/foo_openlyrics/issues/252#issuecomment-1509822519, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADKEMP5E3SDTE4C3Z26ESFTXBKODPANCNFSM6AAAAAAW2HR2CI. You are receiving this because you authored the thread.Message ID: @.***>

jacquesh commented 1 year ago

Sure but that sucks and is a painful manual process of trial-and-error. Is it not strictly better to use the existing "Sync line..." functionality I mentioned above to open the editor, click the button at the right point in time and now you're immediately done?

ngs428 commented 1 year ago

I will give that a try. It sounds better.

From: Jacques Heunis @.> Sent: Saturday, April 15, 2023 4:25 PM To: jacquesh/foo_openlyrics @.> Cc: ngs428 @.>; Author @.> Subject: Re: [jacquesh/foo_openlyrics] Add Feature to Change Offset (Issue #252)

Sure but that sucks and is a painful manual process of trial-and-error. Is it not strictly better to use the existing "Sync line..." functionality I mentioned above to open the editor, click the button at the right point in time and now you're immediately done?

— Reply to this email directly, view it on GitHubhttps://github.com/jacquesh/foo_openlyrics/issues/252#issuecomment-1509975474, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADKEMP6KAKW3ZUVZ5FCUD5LXBMG35ANCNFSM6AAAAAAW2HR2CI. You are receiving this because you authored the thread.Message ID: @.***>