search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
403 stars 24 forks source link

Allow Unsynced Lyrics To Use Highlight Color #255

Open discardedtelepathy opened 1 year ago

discardedtelepathy commented 1 year ago

It would be nice to have lyrics that are not synced to use the highlight color by default. This allows the lyrics to be seen if someone is using a black background and forcing the highlighted lyric to be a different color other than black.

jacquesh commented 1 year ago

I'm unlikely to change the default, but it makes sense to let the user decide whether unsynced lyrics use the "text" or "highlight" colour. Or, possibly more intuitively, allow unsynced lyrics to use their own colour configuration that is independent of the colours used for synced lyrics.

discardedtelepathy commented 1 year ago

Currently, when having a black background and using black for the un-highlighted lyrics, you cannot see the lyrics if it pulls lyrics that are unsynced. Having the ability to use the highlight color or a different color for unsynced lyrics would prevent this from happening.

I find with new songs added to library it doesn't always pull synced lyrics(maybe they dont exist anywhere yet, etc) This makes it easier to notice when it pulls lyrics. There are other reasons this functions that would provide a better user experience overall.

Thank you for your time.