Open jacquesh opened 1 year ago
While I understand your concerns, being honest I don't see this as a problem. Why would you manually download a hundred of lyrics when you can use the bulk search? Makes zero sense to do that.
Regular users don't hack features to bypass artificial limitations. Developers do. And developers (or like-minded users) would simply use other tools for this (much more suitable), not foobar with manual playback.
Just my POV so you don't speed energy with things which are not relevant at all compared to other things.
We'd like to avoid spamming remote sources with requests. Currently we do this for bulk-search where we introduce a delay between requests (and bulk-search is not meant to be fast/interactive anyway). However there is still the potential for a user to start a playlist and then spam "next" to blast through many tracks and trigger searches for all of them.
How common is this? I don't know. I would expect it to be quite rare, so maybe its not worth the implementation/maintenance complexity.
We could let it allow some burst (so the user can make, say, 3 requests in quick succession before getting throttled) and then have it add a delay before each search that...maybe ramps up with additional requests until it reaches the delay we use in bulk-search? Seems like it'd feel bad if we snapped right up to the bulk-search delay but maybe if the burst allowance is large enough its fine? This is the sort of thing that metrics are meant to help with.