jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
449 stars 26 forks source link

Accessibility feature: Support Esc/Alt-c to abort, Alt-a for Apply and Alt-o for OK #278

Open H2Swine opened 1 year ago

H2Swine commented 1 year ago

To rely less on mouseclicks: Alt+<letter, typically the first> is fairly common, and it is supported widely in foobar2000, like file Properties dialogue.

Sure I will - at least for now - have to double click to enter the lyrics editor quickly, but still: when done editing (with keyboard unless it is for syncing), then I would wish for the standard keyboard shortcuts to apply.

jacquesh commented 1 year ago

Related to #133

H2Swine commented 1 year ago

Don't know whether to mention it here or in #133 , but: Ctrl-Enter is foobar2000ish for inserting a linebreak when editing fields.

Slightly odd not to use Alt-Enter, but I guess one needs to adapt to it and don't touch Ctrl-Enter.

jacquesh commented 1 year ago

Ctrl-Enter is foobar2000ish for inserting a linebreak when editing fields.

Can you give an example of where this is the case? I tried a small handful of text fields that are built into fb2k (IE not provided by 3rd-party components) and none of them appeared to have this behaviour (although admittedly I couldn't find anything that was explicitly a multi-line input field so maybe it's just those?)

H2Swine commented 1 year ago

Select a file, enter file properties with Alt-Enter. Double-click any field, say Date - the field name in the left column, not the value column! Or navigate to it and Alt-Enter. A small window with "Edit value : Date" opens. Start typing and hit Ctrl-Enter (or Shift-Enter, actually!) for newline. (Not Enter which works like "OK" - and not Alt-Enter, which does nothing.)

The field does not need to be multiline field. That's why I used Date as an example. (Multi-value? Difference will be, if you do this to a multi-value field, there is text "Use ; character to separate multiple values." below the edit window.

That fb2k uses Alt-Enter to open properties explains why it is not used for newline, of course. But now both Alt-Enter, Shift-Enter, Ctrl-Enter and Enter are in use ...