search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
450 stars 26 forks source link

Add dark theme for the manual lyrics search popup #302

Open Velocidensity opened 1 year ago

Velocidensity commented 1 year ago

Lyric editor and other popups already use dark theme, if enabled (on foobar2000 v2.0), but the lyrics search window does not.

jacquesh commented 1 year ago

The same is true for bulk search. This is because at the time that I added dark mode support, fb2k's dark mode theming didn't properly support lists that had items added after dialog creation. I could try this again some time to see if that's changed.

jacquesh commented 2 months ago

Update: I did try this again recently and the usual shim that just auto-magically makes everything support darkmode still doesn't seem to work for lists. I guess bulk-search shouldn't need items added after dialog creation so maybe I should give that one another shot...

There is some dark mode sample code that includes a list but it works because it's using all the libPPUI infrastructure, which I am otherwise not, so taking that approach would require both learning how to use that, and also rewriting the entire dialog, neither of which I'm particularly keen to do any time soon.