jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
450 stars 26 forks source link

Musixmatch search skipping results? #303

Open Velocidensity opened 1 year ago

Velocidensity commented 1 year ago

It seems sometimes Musixmatch doesn't give the desired results. I've had this issue with David Bowie's Blackstar before, but as I was writing the issue for the first time, it appeared in the manual search, so I scrapped it. I've now ran into the same issue looking for Stevie Wonder's Isn't She Lovely. The plugin doesn't seem to see those lyrics, from Songs in the Key of Life (even when searching with no album name), but it sees this result from a different album.

Steps to (hopefully) reproduce

  1. Open manual lyrics search for a track.
  2. Search for "Isn't She Lovely" from the "Songs in the Key of Life" album by "Stevie Wonder".
  3. Only result from Musixmatch appears to be the one by Nigel Kennedy.

Expected behavior

Open Lyrics correctly finds the correct result.

Versions

Debug logs

WARN-OpenLyrics: Failed to download darklyrics.com page http://darklyrics.com/lyrics/steviewonder/songsinthekeyoflife.html: Object not found

Additional information

I've tried searching multiple times, haven't been able to get the right result.

jacquesh commented 1 year ago

Could you please add logs with the extra "debug logging" enabled? That should give a bit more info on why the musixmatch results were ignored. (I should really add this to the issue template): Preferences -> OpenLyrics -> Display -> Debug logging enabled.

I can take a look, but if the correct lyric doesn't show up in manual search then there probably isn't much we can do.

Velocidensity commented 1 year ago

Sorry, I didn't see the debug logging option. Here's the log:

Debug log ``` INFO-OpenLyrics: Searching for lyrics using custom parameters... INFO-OpenLyrics: Querying for track ID from https://apic-desktop.musixmatch.com/ws/1.1/track.search?user_language=en&app_id=web-desktop-app-v1.0&subtitle_format=lrc&q_artist=Stevie%20Wonder&q_album=Songs%20in%20the%20Key%20of%20Life&q_track=Isn%27t%20She%20Lovely&usertoken= INFO-OpenLyrics: Querying for song ID from https://music.163.com/api/search/get?s=Stevie%20Wonder+Isn%27t%20She%20Lovely&type=1&offset=0&sub=false&limit=5... INFO-OpenLyrics: Querying for lyrics from https://www.azlyrics.com/lyrics/steviewonder/isntshelovely.html... INFO-OpenLyrics: Querying for lyrics from http://darklyrics.com/lyrics/steviewonder/songsinthekeyoflife.html... INFO-OpenLyrics: Searching for lyrics in tag: 'SYNCEDLYRICS' INFO-OpenLyrics: Querying for song ID from https://c.y.qq.com/splcloud/fcgi-bin/smartbox_new.fcg?inCharset=utf-8&outCharset=utf-8&key=Stevie%20Wonder+Isn%27t%20She%20Lovely... INFO-OpenLyrics: Save file name format 'Lyrics/%filename%' with directory class 'TrackFileDirectory' evaluated to 'file://D:\Music\Stevie Wonder - Songs In The Key Of Life (1976)\Lyrics\11. Isn't She Lovely' INFO-OpenLyrics: Querying for lyrics in file://D:\Music\Stevie Wonder - Songs In The Key Of Life (1976)\Lyrics\11. Isn't She Lovely.lrc... INFO-OpenLyrics: Querying for lyrics in file://D:\Music\Stevie Wonder - Songs In The Key Of Life (1976)\Lyrics\11. Isn't She Lovely.txt... INFO-OpenLyrics: Found 1 lyrics in local files: file://D:\Music\Stevie Wonder - Songs In The Key Of Life (1976)\Lyrics\11. Isn't She Lovely INFO-OpenLyrics: Lookup local-file file://D:\Music\Stevie Wonder - Songs In The Key Of Life (1976)\Lyrics\11. Isn't She Lovely.lrc for lyrics... INFO-OpenLyrics: Successfully retrieved lyrics from file://D:\Music\Stevie Wonder - Songs In The Key Of Life (1976)\Lyrics\11. Isn't She Lovely.lrc INFO-OpenLyrics: Loaded lyrics already form a valid UTF-8 sequence INFO-OpenLyrics: Parsing LRC lyric text... INFO-OpenLyrics: Expanding lyric text... WARN-OpenLyrics: Failed to download darklyrics.com page http://darklyrics.com/lyrics/steviewonder/songsinthekeyoflife.html: Object not found INFO-OpenLyrics: Successfully retrieved lyrics from https://www.azlyrics.com/lyrics/steviewonder/isntshelovely.html INFO-OpenLyrics: Loaded lyrics already form a valid UTF-8 sequence INFO-OpenLyrics: Parsing LRC lyric text... INFO-OpenLyrics: Get Musixmatch lyrics lyrics from https://apic-desktop.musixmatch.com/ws/1.1/track.lyrics.get?user_language=en&app_id=web-desktop-app-v1.0&commontrack_id=1140285&usertoken= INFO-OpenLyrics: Page https://genius.com/stevie-wonder-isnt-she-lovely-lyrics retrieved INFO-OpenLyrics: Successfully retrieved lyrics from https://genius.com/stevie-wonder-isnt-she-lovely-lyrics INFO-OpenLyrics: Loaded lyrics already form a valid UTF-8 sequence INFO-OpenLyrics: Parsing LRC lyric text... INFO-OpenLyrics: Loaded lyrics already form a valid UTF-8 sequence INFO-OpenLyrics: Parsing LRC lyric text... INFO-OpenLyrics: Get QQMusic lyrics for song ID 00311dwe43P0ak from http://c.y.qq.com/lyric/fcgi-bin/fcg_query_lyric_new.fcg?g_tk=5381&format=json&inCharset=utf-8&outCharset=utf-8&songmid=00311dwe43P0ak... INFO-OpenLyrics: Get NetEase lyrics for song ID 21612684 from https://music.163.com/api/song/lyric?tv=-1&kv=-1&lv=-1&os=pc&id=21612684... INFO-OpenLyrics: Loaded lyrics already form a valid UTF-8 sequence INFO-OpenLyrics: Parsing LRC lyric text... INFO-OpenLyrics: Found LRC offset: 0ms INFO-OpenLyrics: Get QQMusic lyrics for song ID 001vP5XY3PMjoV from http://c.y.qq.com/lyric/fcgi-bin/fcg_query_lyric_new.fcg?g_tk=5381&format=json&inCharset=utf-8&outCharset=utf-8&songmid=001vP5XY3PMjoV... INFO-OpenLyrics: Loaded lyrics already form a valid UTF-8 sequence INFO-OpenLyrics: Parsing LRC lyric text... INFO-OpenLyrics: Get NetEase lyrics for song ID 21612837 from https://music.163.com/api/song/lyric?tv=-1&kv=-1&lv=-1&os=pc&id=21612837... INFO-OpenLyrics: Loaded lyrics already form a valid UTF-8 sequence INFO-OpenLyrics: Parsing LRC lyric text... INFO-OpenLyrics: Loaded lyrics already form a valid UTF-8 sequence INFO-OpenLyrics: Parsing LRC lyric text... INFO-OpenLyrics: Get NetEase lyrics for song ID 1936975 from https://music.163.com/api/song/lyric?tv=-1&kv=-1&lv=-1&os=pc&id=1936975... INFO-OpenLyrics: Loaded lyrics already form a valid UTF-8 sequence INFO-OpenLyrics: Parsing LRC lyric text... INFO-OpenLyrics: Get NetEase lyrics for song ID 21612952 from https://music.163.com/api/song/lyric?tv=-1&kv=-1&lv=-1&os=pc&id=21612952... INFO-OpenLyrics: Loaded lyrics already form a valid UTF-8 sequence INFO-OpenLyrics: Parsing LRC lyric text... INFO-OpenLyrics: Get NetEase lyrics for song ID 21612755 from https://music.163.com/api/song/lyric?tv=-1&kv=-1&lv=-1&os=pc&id=21612755... INFO-OpenLyrics: Loaded lyrics already form a valid UTF-8 sequence INFO-OpenLyrics: Parsing LRC lyric text... INFO-OpenLyrics: Finished loading lyrics from a custom search ```
Velocidensity commented 1 year ago

There appears to be an endpoint which is capable of retrieving more lyrics, at least in some cases. For example 100 gecs - xXXi_wud_nvrstøp_ÜXXx fails with the one openlyrics uses, but works with another one.

INFO-OpenLyrics: Querying for track ID from https://apic-desktop.musixmatch.com/ws/1.1/track.search?user_language=en&app_id=web-desktop-app-v1.0&subtitle_format=lrc&q_artist=100%20gecs&q_album=1000%20gecs&q_track=xXXi_wud_nvrst%C3%B8p_%C3%9CXXx&usertoken=

https://apic-desktop.musixmatch.com/ws/1.1/macro.subtitles.get?user_language=en&app_id=web-desktop-app-v1.0&subtitle_format=lrc&q_artist=100%20gecs&q_album=1000%20gecs&q_track=xXXi_wud_nvrst%C3%B8p_%C3%9CXXx&usertoken= - returns lyrics correctly