search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
401 stars 24 forks source link

Background won't display GIF image #308

Open redactedscribe opened 8 months ago

redactedscribe commented 8 months ago

Steps to reproduce

  1. The album art of a file must be a GIF (mine's alongside the file, not embedded, if that matters).
  2. Enable using album art as the background image.

Expected behavior

Although GIF album art is rare (this one is static, not animate), they are sometimes distributed with releases. Ideally the component could render them just like it does JPGs (and others?).

Versions

Debug logs

WARN-OpenLyrics: Failed to load album art image
jacquesh commented 8 months ago

Actually I'm not sure this is a bug. Since openlyrics just uses whatever album art data fb2k provides and I can't get it to provide album art data from a .gif file at all. If I have a cover.png file next to the media file, it loads that, but if I have a cover.gif it doesn't load anything at all.

Does your album art show on fb2k's built-in "Album Art Viewer" panel? The fb2k SDK API suggests that it only supports png and jpg files, in which case it would be a lot more work to support other file types.

redactedscribe commented 8 months ago

Does your album art show on fb2k's built-in "Album Art Viewer" panel? The fb2k SDK API suggests that it only supports png and jpg files, in which case it would be a lot more work to support other file types.

It likely does not. I use Spider Monkey Panel for my album art so that's why I can probably see it there as it likely has some GIF lib included.

Actually I'm not sure this is a bug. Since openlyrics just uses whatever album art data fb2k provides and I can't get it to provide album art data from a .gif file at all. If I have a cover.png file next to the media file, it loads that, but if I have a cover.gif it doesn't load anything at all.

This makes sense. It's not a bug, but a feature request then I guess!