search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
432 stars 24 forks source link

FR: Album art / custom images: Maintain aspect ratio but also scale image to fit #309

Open redactedscribe opened 11 months ago

redactedscribe commented 11 months ago

First off, thanks for the recent v1.7. Appreciated.

Additional scaling option: Maintain aspect ratio but also scale image to fit. This would leave no blank areas in the lyrics window by scaling and clipping the image to achieve it.

Thanks.

jacquesh commented 11 months ago

I don't follow, it already does this. Do you mean you want it to scale to the smallest axis and clip off the extra bits on the other axis, rather than scaling to the largest axis and having the background showing on the other axis (which is what it currently does)?

Maybe you could provide a simple illustration to explain?

redactedscribe commented 11 months ago

I don't follow, it already does this. Do you mean you want it to scale to the smallest axis and clip off the extra bits on the other axis, rather than scaling to the largest axis and having the background showing on the other axis (which is what it currently does)?

This is exactly what I want. Scale to the smallest axis so that the largest axis is being clipped. See the CSS object-fit: cover; example here: https://www.w3schools.com/csS/css3_object-fit.asp

I don't want to be able to see the background colour behind the background image in the lyrics window.