search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
432 stars 24 forks source link

Search for Lyrics not more working with DSF Files #311

Closed Roendi61 closed 11 months ago

Roendi61 commented 11 months ago

Steps to reproduce

  1. Search for Lyrics
  2. Status found
  3. Show Lyrics: No lyrics saved

Expected behavior

It works maby 1 Year ago. Longtime I run only the wizzard with out controlling the Files. So I have no Idea when the Problem starte

Versions

1.7 * foobar2000 version: 2.0 x86 * OpenLyrics version: 1.7 I check some older versions. allways the same #### Debug logs

Additional information

console-2023-10-26-10-48-05-P12976.txt

jacquesh commented 11 months ago

The log you uploaded shows it saving to metadata tags. Specifically the UNSYNCED LYRICS tag.

Can you be a bit more specific about what you mean by "Show Lyrics: No lyrics saved"? Do you mean it searches the internet every time?

The log you provided does not show any search for Metadata tags. Can you try adding the "Metadata tags" source to the top of your search list and see if that fixes it?

Roendi61 commented 11 months ago

Hi Jaquesh You have the position search for Lyrics. This show all like it works. But when you go to the position: Show Lyrics: it say: No Lyrics saved. And its troue. Her another example with a older File. Is on unsynced Lyrics. I can see that with my DBpoweramp Edit ID Tag Tool Lyrics working

I have no Settings like bevor. Settings

The log you provided does not show any search for Metadata tags. Can you try adding the "Metadata tags" source to the top of your search list and see if that fixes it? search

Nothing change

jacquesh commented 11 months ago

I'm struggling to understand the problem you're experiencing. You say that "Show lyrics" doesn't work, but then you provide a screenshot where it clearly is working. You say that "Search for lyrics" is working, but the logs you provided show it searching QQMusic and Netease (the default providers) and not any others (in particular not Metadata tags).

You mention that you can see the tags (that openlyrics doesn't find) using dbpoweramp. Is that true when those lyrics tags were saved by openlyrics itself (such as the one shown in the log you provided)? Or are these only files that were saved previously? Does openlyrics load the tags saved in the log you uploaded?

Roendi61 commented 11 months ago

I feel the same way. But no matter. I will now describe and document the exact error process.

Step 1: Search for lyrics with Open lyrics Suche

Step 2: Lyrics found Found

Step 3: Display lyrics Show lyrics

Step 4: No lyrics saved No Lyrics

I hope the Prozess is now clear for you

Roendi61 commented 11 months ago

I do the same with a Flac File. And with Flac the program works fine. Its only a Problem with DSF Files.

jacquesh commented 11 months ago

Ooooh, sorry now I understand. The problem is the *.dsf files. Right. I believe decoding for those is provided by a 3rd-party component, it's not supported natively in fb2k, correct? Do we have any evidence that said plugin supports saving to metadata tags using the usual fb2k tag-editing code? I expect it does not because openlyrics doesn't pay any attention to the format, it just uses the built-in APIs for modifying tags.

I recommend either saving to file or converting those files to another format.

Roendi61 commented 11 months ago

OK No problem I recommend either saving to file or converting those files to another format. Both are not a valid option at the Moment. Thanks for your support