jacquesh
commented
1 year ago That's very strange, we don't really do much in terms of darkmode handling, we just tell fb2k to make whatever changes it needs. In this case that's just flipping the colour it gives you when you ask for the "UI background colour".
I did a quick test and I do not see this on my machine (it works as expected). It could be a bug in the recent/beta fb2k releases? Can you please try with default UI with the latest stable version of fb2k (v2.0) and see if you get the same result?
username116
Hi,
The lyrics panel does not follow foobar's color mode when changing light or dark mode. I'm using Columns UI. With Default UI, it's even stranger: the colors are reversed.
video with Columns UI
https://github.com/jacquesh/foo_openlyrics/assets/108369600/17b1247d-0bb2-4ae1-aa5e-9ed0096252c1video with Default UI
https://github.com/jacquesh/foo_openlyrics/assets/108369600/02c21d50-6b31-4870-8b9e-4505c80f38c7Steps to reproduce
Expected behavior
Lyrics panel colors should follow foobar's color mode.
Versions
Debug logs
(in Columns UI) There's nothing in the console when the color mode is changed, even with 'Debug logging enabled'.
When I launch the song, the console says this:
console
``` Opening track for playback: "D:\Audio\Musique\Pop, rock\Aldous Harding\2014 - Aldous Harding\08. Small bones of courage.flac" INFO-OpenLyrics: LyricPanel::compute_background_image took 1316us ReplayGain DSP in track mode INFO-OpenLyrics: No search avoidance info available for track INFO-OpenLyrics: Searching for lyrics for artist='Aldous Harding', album='Aldous Harding', title='Small bones of courage'... INFO-OpenLyrics: Searching for lyrics in tag: 'LYRICS' INFO-OpenLyrics: Found lyrics in tag: 'LYRICS' INFO-OpenLyrics: Searching for lyrics in tag: 'SYNCEDLYRICS' INFO-OpenLyrics: Searching for lyrics in tag: 'UNSYNCEDLYRICS' INFO-OpenLyrics: Searching for lyrics in tag: 'UNSYNCED LYRICS' INFO-OpenLyrics: Successfully retrieved lyrics from source: Metadata tags INFO-OpenLyrics: Parsing lyrics text... INFO-OpenLyrics: Loaded lyrics already form a valid UTF-8 sequence INFO-OpenLyrics: Parsing LRC lyric text... INFO-OpenLyrics: Lyric loading complete INFO-OpenLyrics: Skipping lyric save. Type: 1, Local: yes, Timestamped: no, Autosave: 0 ReplayGain DSP: gain data is missing. DSP managed to scan 105.5 seconds of the track and will use the scanned data as estimate. Found gain -4.31 dB ```Additional information
The panel is in a tab in Columns UI. There is only one lyrics panel. When I restart foobar, the lyrics panel colors change to the correct colors.
Here are the settings:
settings
 