Open sveakul opened 6 months ago
Thanks for the examples. Tagging @H2Swine for visibility in case they'd like to add anything or track this.
For completeness, the comment you're referring to is in #253 (specifically this one)
Just for simple examples in the Metal Archives lyrics URL format: Available: https://www.metal-archives.com/release/ajax-view-lyrics/id/1234 Not available: https://www.metal-archives.com/release/ajax-view-lyrics/id/12345
FWIW, including the emphasis code (em) in the "not available" string proved to be important when dealing with this issue on a text level in the ESLyric plugin.
@jacquesh show a popup to notify user of new features and sources I just remembered metal-archived is added
This is just to chime in on your message to H2Swine about having Openlyrics continue to search past Metal Archives if the results produce a "(lyrics not available)" return.
The Metal Archives website returns the message "(lyrics not available)" if an Advanced Search (Band and song title) DOES find a hit for that band and song on the website but the lyrics for that song are not available to them. In that case, clicking on the "Lyrics" column in the Search results will show the "(lyrics not available)" message below the search results line. A full example is below:
It would be nice if OpenLyrics could interpret that as a non-hit and just continue to another provider. Another popular source that behaves like this is SongLyrics, which in the same circumstance will return a message "We do not have have the lyrics for (song title) yet" and the search stops. Example from website: