search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
401 stars 24 forks source link

Autosave lyrics from external file to metadata tags. #324

Closed nonylours closed 5 months ago

nonylours commented 5 months ago

Hello, I would like to know if there is a way to autosave lyrics from an .lrc file to a tag.

Expected behavior

My open lyrics configuration looks like this :

Capture1 Capture2

The lyrics files are in a separate folder and the music files don't have any lyrics tag.

When I use the search for lyrics feature, the lyrics are found but tags are not saved even when the save method is set to save to tags and autosave is set to always.

The only way to save the lyrics to tags is to play a song one by one, right click on the lyrics panel and choose save lyrics.

Versions

Debug logs

Log when searching for lyrics for 1 song :

INFO-OpenLyrics: Spawning bulk search window... INFO-OpenLyrics: Initializing bulk search window... INFO-OpenLyrics: Searching for lyrics for artist='Cheekface', album='Too Much to Ask', title='Featured Singer'... INFO-OpenLyrics: Save file name format '%isrc%' with directory class 'Custom('D:\Download\lyrics')' evaluated to 'D:\Download\lyrics\QM3DF2178521' INFO-OpenLyrics: Querying for lyrics in D:\Download\lyrics\QM3DF2178521.lrc... INFO-OpenLyrics: Querying for lyrics in D:\Download\lyrics\QM3DF2178521.txt... INFO-OpenLyrics: Found 1 lyrics in local files: D:\Download\lyrics\QM3DF2178521 INFO-OpenLyrics: Lookup local-file D:\Download\lyrics\QM3DF2178521.lrc for lyrics... INFO-OpenLyrics: Successfully retrieved lyrics from D:\Download\lyrics\QM3DF2178521.lrc INFO-OpenLyrics: Successfully looked-up lyrics from source: Local files INFO-OpenLyrics: Parsing lyrics text... INFO-OpenLyrics: Loaded lyrics already form a valid UTF-8 sequence INFO-OpenLyrics: Parsing LRC lyric text... INFO-OpenLyrics: Lyric loading complete INFO-OpenLyrics: Skipping lyric save. Type: 2, Local: yes, Timestamped: yes, Autosave: 1

Thanks for your help.

nonylours commented 5 months ago

Apparently it was a feature added in version 1.5. I will use V1.4 for now. Thanks.

Version 1.5 (2023-04-03)

Behaviour changes:

  • Avoid saving lyrics if they're loaded from a local source during search