search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
401 stars 24 forks source link

Autosave doesn't respect Never option #327

Closed Azuriye closed 5 months ago

Azuriye commented 5 months ago

I have disabled the Autosave feature (set it Never) but when searching for the lyrics manually and hitting the OK or Apply option the lyric file gets saved locally instead of just displaying them on the foobar2k lyric panel.

Steps to reproduce

  1. Search for lyrics (manually)
  2. Highlight any search
  3. Click the OK or Apply button
  4. Check the File Explorer to confirm the lyric file is saved.

Expected behavior

It shouldn't save the file without the user manually right-clicking the lyric and using the Save Lyrics option. But instead when hitting Apply or OK (not sure which button will be more meaningful in this context) it should only display the lyrics on the lyric panel.

Versions

Debug logs

console.txt (I've clicked the Apply button and OK button as well hence you can see there's two save files)

Azuriye commented 5 months ago

Okay I've just searched up and there seems to be a similar issue as well reported 2 years ago.

Just to make things clear, in the old lyric plugin hitting Apply or OK (Not sure which button it was) only displays the lyrics on the panel which was helpful for me to quickly identify if the lyrics matched the song or not.

Instead of entirely relying on the Lyric preview panel when searching manually it'd be better for the user to click either OK or Apply, or maybe change the functionality of the Apply button? So that the user can Apply multiple lyrics from the manual search to see which lyric he/she is satisfied with.

jacquesh commented 5 months ago

Duplicate of #89