jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
432 stars 24 forks source link

Is there a way to have this component save synced lyrics even if there was already a previously unsynced lyrics saved for the same song? #328

Open DitherMan420 opened 8 months ago

DitherMan420 commented 8 months ago

So here's an example. I have unsynced lyrics saved for Song A. Later on, synced lyrics are available for Song A. It does NOT save the synced lyrics since there's already UNsynced lyrics saved. Is there a way to have it overwrite unsynced lyrics with synced lyrics, always? Right now it only lets you save ONLY synced lyrics. I want to save ALL lyrics, but if a synced version comes out later, I want that to overwrite the unsynced one. Hope that makes sense. Thanks!

jacquesh commented 8 months ago

This should happen already when saving to file. For safety we avoid auto-saves that would overwrite existing files but synced and unsynced lyrics get saved to different files by default so that's fine. The same cannot be said for saving to tags however, because there is only one widely-supported "lyrics" tag and foobar does special things with it. Are your lyrics being saved to tags or files?

It's possible that there's a bug related to the logic that avoids overwriting existing data automatically. Could you please add debug logs covering a minimal reproduction of the issue (as per the issue template)? That should help clearing up exactly what's happening here.

Right now it only lets you save ONLY synced lyrics.

In a literal sense this isn't true (there's a setting for it and it has 3 other options) but I assume what you actually mean is "there isn't the option to auto-save everything but overwrite unsynced lyrics with synced ones". Is that accurate?