search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
401 stars 24 forks source link

Remove auto search when "search for lyrics (manually)" is clicked #330

Open shendongdebing opened 5 months ago

shendongdebing commented 5 months ago

Most of the music file information is incorrect, and the plugin's automatic search has failed. Therefore, we need to manually search by changing some information and then initiating the search. Currently, manual searches trigger an automatic search first, and we have to wait for it to finish. So, I am considering either removing the auto-search feature in the popup window or enabling the "search" button at any time for faster workflow.

jacquesh commented 5 months ago

Openlyrics is fundamentally (and by necessity) dependent on the quality of your tagging of your own media. If your media is minimally/badly tagged you're not going to have a good time. There is nothing that I (or anybody else) can do about this. So in general I'm going to assume that all of your media is reasonably tagged so that at the very least it has an Artist and Title, and that those tags are usually correct.

That said, I acknowledge that there are certainly exceptions. Those exceptions are what manual search is for. I myself have run into the annoyance you describe where I know what the problem is with the tags so I'm going to open the manual search and then immediately have to change the tags and wait.

Between removing auto-search and allowing you to cancel the existing search, I'm not sure which I'd prefer. The auto-search is handy because it avoids the extra click in what is at least for me the common case where the tags are correct but I just have old/bad lyrics. Being able to cancel the existing search would in general be an improvement but is non-trivial to implement cleanly and would need some rate-limiting to avoid abuse. I'm open to arguments either way.

shendongdebing commented 5 months ago

The auto-search in the manual popup window sends identical requests to the runtime auto-search, using the same information as parameters. It essentially duplicates the work performed by the runtime auto-search. This feels like my own "SISYPHUS." By the way, it's just a feature suggestion, no arguments :-)

Krimsar commented 2 months ago

For what it's worth: I would prefer you to allow to cancel the search instead of not starting it, because I mainly use the "Search for lyrics (manually)" feature for updating old or badly formatted lyrics for files with proper tags. The fact that the search starts automatically is quite handy in this scenario.

edit: The only scenario where I personally would prefer to cancel this search is when I have incorrect tags intentionally like "Smashing Pumpkins, The" for sorting purposes.