[Source][Genius]Songs with featuring artist is named different. Problem is &/and ,/and

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000

MIT License

401 stars 24 forks source link

[Source][Genius]Songs with featuring artist is named different. Problem is &/and ,/and #340

Open Rexadev opened 4 months ago

Rexadev commented 4 months ago

Steps to reproduce

Expected behavior

https://genius.com/Dimitri-vegas-and-like-mike-and-david-guetta-complicated-lyrics

Versions

foobar2000 version: 2.0
OpenLyrics version: 1.8

Debug logs

ERROR-OpenLyrics: Error of unrecognised type while searching AZLyrics.com
Library scanning problem: "...\1 foobar2000 v2 Portable\profile\eslyric-data\scripts\lib\crypto-es\lib\index.d.ts", reason: Unsupported format or corrupted file
Opening track for playback: "...\Dimitri Vegas & Like Mike, David Guetta, Dimitri Vegas, Kiiara\Complicated.opus"
WARN-OpenLyrics: Failed to download darklyrics.com page http://darklyrics.com/lyrics/dimitrivegaslikemike/complicated.html: Object not found
WARN-OpenLyrics: Failed to download genius.com page https://genius.com/dimitri-vegas-and-like-mike-complicated-lyrics: Forbidden (403)
ERROR-OpenLyrics: Error of unrecognised type while searching AZLyrics.com

Additional information

jacquesh commented 4 months ago

As per the bug issue template: Please include debug logs of a minimal reproduction of the issue.

jacquesh commented 4 months ago

Your artist tag doesn't include and David Guetta at the end, and that's what Genius expects. We're not using a search API for Genius, we're just looking up the exact page for the track being searched. If the URL we compute for that doesn't exactly match what Genius used then it won't find it.

Rexadev commented 4 months ago

we're just looking up the exact page for the track being searched. If the URL we compute for that doesn't exactly match what Genius used then it won't find it.

That the problem. &/and ,/and/vs

Same song with artists listed differently -

https://en.wikipedia.org/wiki/Complicated_(Dimitri_Vegas_%26_Like_Mike_and_David_Guetta_song) Complicated (Dimitri Vegas & Like Mike and David Guetta song) https://www.youtube.com/watch?v=w0EF3AxJwLU Dimitri Vegas & Like Mike vs David Guetta ft. Kiiara - Complicated (Official Music Video) https://genius.com/Dimitri-vegas-and-like-mike-and-david-guetta-complicated-lyric Complicated [Dimitri Vegas & Like Mike & David Guetta]

jacquesh commented 4 months ago

Sure, but this isn't a bug, it's just that your tags don't match the exact format they would need in order to find results on Genius. Not finding them in this case is unfortunate but that's why there are other sources.