jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
401 stars 24 forks source link

Hide all metadata fields and don't move them #353

Open PlaylistsTrance opened 3 months ago

PlaylistsTrance commented 3 months ago

I include the editing software and its version in the metadata fields at the start of the LRC file like so:

[ar: Artist]
[ti: Title]
[al: Album]
[by: Username]
[length: MM:SS]
[re: RhythmiKaRuTTE_Spectro]
[ve: 2022-02-22]

However, OpenLyrics now shows the [re: and [ve: lines at the end of the synced lyrics. When editing the lyrics, these metadata lines are also moved at the end of the file. I'm not sure if this behaviour is intended, but if it is, I'd like a way to disable it.

jacquesh commented 3 months ago

The current behaviour is intentional. We only consider a specific set of "keys" to be "tags" to avoid accidentally considering actual lyrics to be tags. I'm open to the idea of changing that. I haven't looked to see if that would result in any change in behaviour for my own lyrics library but I'd be interested to hear people's opinions on it.

PlaylistsTrance commented 3 months ago

I think lines that follow the format [field: value] should always be hidden. For files that have both synced and unsynced lines, I think there should be a toggle to hide the unsynced lines in case there are synced lines.