search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
432 stars 24 forks source link

Add ability to display source of found lyrics #362

Closed sveakul closed 1 month ago

sveakul commented 4 months ago

Please add the ability to see the source where foo_openlyrics found the displayed lyrics.

The use case for this is to make judgements as to what sources are providing the best results for the particular listener and then being able to prioritize those on the search order panel.

This could be added to a right-click panel option like "show source", or selectable as a preface line in the lyrics themselves. Examples below from ESlyric and LSP3/multisource:

eslyric

multi

lsp

jacquesh commented 2 months ago

Very similar to #52

jacquesh commented 2 months ago

I think the main concern here is: Where do we store this information? In LRC we can store it in the tags, but that doesn't work for unsynced lyrics, so we basically need to store it in a metadb in fb2k. That has the downside that if you ever modify them outside of fb2k, that info will just be wrong...although I guess we could also store a hash of the lyrics and compare against that to see if they've been modified ¯_(ツ)_/¯

sveakul commented 2 months ago

My intent on this request involved radio streams only, just so the user could see what site found the lyrics and adapt his search list accordingly. In this case, nothing of course should be "stored" anywhere. I'm sorry if this was misunderstood.

If someone feels they want that information to appear in lyrics being tagged to into an actual file's lyrics frame all they need do is leave it included at the top of the lyrics body instead of editing it out or putting it elsewhere, as is the case with Lyrics Show Panel with the Multisource DLL.

jacquesh commented 2 months ago

It would certainly be simpler to implement, but the problem with not persisting source information is that the source will then just be "local files" (or whatever your save source is) most of the time. That seems a bit unhelpful...

sveakul commented 1 month ago

@jacquesh What is different in this issue compared #187 ? Metadata is stored in f2k ? Why not inside lyrics ?

The difference is that in # 362 all I am asking for is the ability to display the source of the found lyrics at the time of display (i.e., "Genius") not the 9-value stored metadata mentioned in # 187.