search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
449 stars 26 forks source link

[Site Request] LRCLib #367

Closed Tenome closed 4 months ago

Tenome commented 5 months ago

https://lrclib.net https://github.com/tranxuanthang/lrcget

A privately-run open source synced (and plaintext) lyrics server. It mainly gets its lyrics from Musixmatch, but you can also easily submit new lyrics (and it lets you download their database), which I've been going since Minilyircs is a pain in the ass and doesn't let you browse/download their DB. It also has an API.

jacquesh commented 5 months ago

Oh cool, I didn't know that existed. I've actually been kinda tempted to build something like that myself a few times. Good to know I don't have to, nice!

API availability is super useful and it even has a submission API that I think it would be neat to try support sometime.

Rexadev commented 5 months ago

are you adding lrclib.net as source or the database functionality or the server @jacquesh

Tenome commented 5 months ago

Being able to submit lyrics would be useful. the LRCGET app is kinda janky.

sveakul commented 4 months ago

https://lrclib.net https://github.com/tranxuanthang/lrcget

A privately-run open source synced (and plaintext) lyrics server. It mainly gets its lyrics from Musixmatch, but you can also easily submit new lyrics (and it lets you download their database), which I've been going since Minilyircs is a pain in the ass and doesn't let you browse/download their DB. It also has an API.

I support adding LRCLIB as a lyrics source in the strongest possible terms. Since it was added to the AIMP player (by user-supplied script) and the ESLyric plugin it has ended up being like another Genius for me--FAST retrieval and a huge pool of results.

Caveat: the site includes both static and synced lyrics, and the API provides a way to choose one as preferred and only fall back to the other if no results are initially found. The "synced" offerings are rather dismal and therefore a plugin should always be set to prefer static lyrics, unless you can make a way to "toggle" between choices. Also, "album" needs to be excluded from the search if it is to work with radio streams, which never include that value.

Velocidensity commented 4 months ago

If you add this source, please add a toggle for synced/unsynced. I only ever need synced lyrics, and so far this source has proven invaluable for explicit tracks, which frequently have no results on Musixmatch, and where the Chinese sites only have terribly formated and censored lyrics.

Tenome commented 4 months ago

ESLyric has the source included in the meantime if anyone wants it.

sveakul commented 4 months ago

The one direct from ESLyric will not work as-is with radio streams because it requires album name. TT put out code changes for streams on the Foobar forum, which I incorporated into the original with the addition of fixed lyrics being preferred with a fallback to sync; it is downloadable here: https://hydrogenaud.io/index.php?action=dlattach;topic=122571.0;attach=31141

jacquesh commented 4 months ago

I've added the source, so that'll be in the next release.

The issue of preferring synced or unsynced though, is in some ways a bit more complicated. The musixmatch source implicitly prefers synced. Already in this thread different people seem to have different preferences in this regard so I can see why you might want it to be configurable. The question then though, is does it really need to be configurable per-source or could it just be a single global "prefer this sort of lyric from sources that appropriately support both" (which would be simpler both to build/maintain and for users to understand/use".

sveakul commented 4 months ago

The question then though, is does it really need to be configurable per-source or could it just be a single global "prefer this sort of lyric from sources that appropriately support both" (which would be simpler both to build/maintain and for users to understand/use".

Thanks for adding LRCLIB, am hoping version 1.10 (or 2.0?) of OpenLyrics is released soon! To your question, if all of the OpenLyrics sources CAN be globally and accurately configurable to prefer either synced or unsynced lyrics "from sources that appropriately support both," I'd be all for it.

Velocidensity commented 4 months ago

Personally, I only care about synced lyrics, and would gladly see a global toggle.

Rexadev commented 2 months ago

Is there a way to report the lyrics - image

jacquesh commented 2 months ago

Not that I'm aware of, but you're welcome to ask for it, since LRCLib is open-source

Rexadev commented 2 months ago

Does LRCLib tell the source ? If yes then add a option to hide duplicates from MusixMatch.