jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
449 stars 26 forks source link

[BandCamp.com] Search pattern not working. #396

Open Rexadev opened 2 months ago

Rexadev commented 2 months ago

Lyrics are here https://derbypdx.bandcamp.com/track/if-ever-theres-a-reason but openlyrics searches http://derby.bandcamp.com/track/if-ever-theres-a-reason

Example 2 - https://darkhelmpune.bandcamp.com/track/jaffar-10th-anniversary-edition Artist name is Dark Helm

Example 3 - https://bleachbathto.bandcamp.com/track/shampoo

Other Solutions https://community.mp3tag.de/t/ws-bandcamp-search-by-album-or-track/17838 https://github.com/ESLyric/scripts/blob/main/searcher/bandcamp.js

API https://bandcamp.com/developer

https://github.com/patrickkfkan/bandcamp-fetch?tab=readme-ov-file#search-api

https://github.com/scriptkittie/bandcamp-api

https://github.com/michaelherger/Bandcamp-API

jacquesh commented 2 months ago

The current implementation just constructs a URL from artist and title directly. I wasn't even aware there was an API but even then I'm a bit confused because the other API repos you link you seem to let you query artists/tracks but I don't see anything like that on the API docs page you linked.

Rexadev commented 2 months ago

I'm a bit confused because the other API repos you link you seem to let you query artists/tracks but I don't see anything like that on the API docs page you linked.

I didn't read much about API. I understand there are undocumented API features as in patrickkfkan's repo like Search which we can use here.

Is it possible to "port" sources from ESLyric https://github.com/ESLyric/scripts/blob/main/searcher/ or MP3Tag ? They both have great sites like MP3Tag has Apple/iTunes, Deezer and ESLyric as Non-English sources and Translation (I Think).