search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
449 stars 26 forks source link

Sources not in search list are returning results #400

Closed ngs428 closed 2 months ago

ngs428 commented 2 months ago

Foobar 2.1.5 x64, OpenLyrics 1.11

I only have 4 sources selected in the left column and those 4 should be the only ones used. When I run a manual search, results from sources in the right show up in the results.

Sources selected: Sources

Results returned (top of list): - Letras and SongLyrics should not be in the results list.
Incorrect Sources

Results returned (bottom of list): Genius and AZLyrics should not be in the results list.
Incorrect Sources 2

Foobartius commented 2 months ago

I reported this recently: https://github.com/jacquesh/foo_openlyrics/issues/392

See the dev.'s reply.

jacquesh commented 2 months ago

Duplicate of #149 as mentioned above.

ngs428 commented 2 months ago

I see now this was mentioned in #149 and #392. That is telling that this keeps coming up. In the other lyric components if a source is on the right side, it is not used. That is the whole point of moving them between columns.

I use manual search as my main mode to find lyrics, probably 95% of the time. Seems like unnecessary searches and results from sources we don’t want searched.

The only reason @jacquesh gave is that it should be used infrequently. As I mentioned, it is the main way I search and I suspect if users are polled it would be much more popular than the bulk search. I never use bulk because it takes so long, I entered that as issue #402.

It would be nice if this could be revisited. Several users have brought this up, and it is counterintuitive to the way the other programs work. Thank you.

jacquesh commented 2 months ago

For future comments on this issue please use #149 as the main place for discussion around this topic, to make it less likely that things get lost.

Certainly this would be more impactful to add now, given that we just added a bunch more sources and in particular LRCLib which sometimes returns many results.

ngs428 commented 2 months ago

Yes, you read my mind. I was just going to reply a few hours back that the current way of handling sources worked well when there were only a few sources, but it is not feasible in the future as more sources are added. This will hit the servers will additional, I will call it, unintended queries. LRCLib I have seen too returns a bunch of results, so the results list is getting very long and I only care about maybe 2 sources at the moment to get what I need.

I will summarize my comments on this one into #149. Just wanted to add this closing comment and I will resume over at #149. Thanks again!