search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
445 stars 26 forks source link

Unnecesary loging #421

Open regorxxx opened 6 days ago

regorxxx commented 6 days ago

Last release spams the console log with things like this:

[18:25:06] INFO-OpenLyrics: metadata tag artist appears multiple times for /Georg Solti/Der ring des Nibelungen - Die walküre/Die walküre: Act 2 vorspiel - Act 2 scene 1. Only the first value will be used of: /Georg Solti/Wiener Philharmoniker. [18:25:06] INFO-OpenLyrics: metadata tag artist appears multiple times for /Awon & Phoniks/Return to the golden era: The remixes/Rule of the gun (Phoniks remix). Only the first value will be used of: /Awon & Phoniks/Awon/Phoniks.

For the final user this serves no purpose at all, specially if you have hundreds of lines like that.

It should be moved to debug logging, if any.

jacquesh commented 4 days ago

All the lines that start with INFO-OpenLyrics should be visible only when debug logging is enabled. A quick check suggests that this is generally working (although I don't have an example on-hand that would reproduce the log above).

Can you confirm if you're seeing these with debug logging disabled?

regorxxx commented 3 days ago

Oh yes, did not mention it but debug logging was disabled. Have double checked it right now, it happens on every startup with logging disabled.