Closed Mrakobes666 closed 2 months ago
@jacquesh When using this. Add option to only search on bandcamp.com when file has source metadata has word bandcamp in it.
Prompted by @Rexadev's request for filtering the search based on tag, I noticed that the tracks I have from bandcamp all include lyrics in their tags. So I checked the motivating example posted above and that has lyrics in tags too. So unless somebody wants to provide a solid justification to handle this as a remote source separately, I'm just going to say "music from bandcamp includes lyrics anyway, so there's no point in adding a separate source for it".
Sure, you may have gotten your music from a store other than bandcamp, but if its available elsewhere then there are probably lyrics elsewhere too?
Prompted by @Rexadev's request for filtering the search based on tag, I noticed that the tracks I have from bandcamp all include lyrics in their tags. So I checked the motivating example posted above and that has lyrics in tags too. So unless somebody wants to provide a solid justification to handle this as a remote source separately, I'm just going to say "music from bandcamp includes lyrics anyway, so there's no point in adding a separate source for it".
Sure, you may have gotten your music from a store other than bandcamp, but if its available elsewhere then there are probably lyrics elsewhere too?
This argument makes no sense when you are talking about Internet radio metadata, which of course doesn't send "lyrics in their tags" or involve getting music from a store. That is my "solid justification to handle this as a remote source separately."
I was very disappointed to see that Bandcamp was not included in the new sources for the 1.10 release, especially when its inclusion was predicted previously . This is a major source for lyrics from the latest independent releases, as already commented on in the first post in this thread.
Please remember the radio stream listeners, lots of whom use OpenLyrics with streams and appreciate its advanced searching and handling properties. Based on the obvious misunderstanding above, I hope you will consider adding Bandcamp after all in a quick 1.10.3 update. Please don't make us wait another year. Thanks for your attention and your advanced plugin.
This argument makes no sense when you are talking about Internet radio metadata, which of course doesn't send "lyrics in their tags" or involve getting music from a store. That is my "solid justification to handle this as a remote source separately."
I don't appreciate the emphasis and quoting here. It comes across to me as rude. I understand why you might be disappointed, but if there is a feature you particularly want, then just like any other permissively-licensed open-source project, you are welcome to take the time yourself to put together a decent-quality pull request that adds it. I don't ever use radio streams, so while I do try to keep them in mind when working on OpenLyrics, they're easy to miss. If that's a major use-case for you, then please try contributing the work needed to support them before berating me for choosing not to add a feature right now that is beneficial primarily to internet radio.
That said, since it was easy to do, I've added a source for Bandcamp to v1.11 (which is on its way out now).
@Rexadev If you would still like the option to only search bandcamp when the metadata contains the "Visit artist.bandcamp.com" message, then please open a dedicated ticket for it. I haven't done that.
I don't appreciate the emphasis and quoting here. It comes across to me as rude. I don't ever use radio streams, so while I do try to keep them in mind when working on OpenLyrics, they're easy to miss. If that's a major use-case for you, then please try contributing the work needed to support them before berating me for choosing not to add a feature right now that is beneficial primarily to internet radio.
I'm sorry for coming across as rude. I was just upset because it seemed like Rexadev's comment about using the genre file tag for searching was going to prevent using Bandcamp as a source for radio streams, as opposed to being just an option, which as I re-read his comment was what he suggested.
I needed the reminder that your plugin need not reflect anyone's else's lyrics usage, especially after reading that you never use radio streams yourself. Thanks for the work you've done for expanding its use by others that you probably never intended originally. I shouldn't have been pressuring you to fit my personal expectations of its development, and for that I apologize.
Searching with pattern is not working for BandCamp.com is Search API possible
Please open a new ticket.
A request for lyrics from a site that has a structure that parses well, this site is a trend for a huge number of musicians
https://deltasleep.bandcamp.com/album/spring-island?from=discover-top