Remote audio/video resources flagged as invalid

jacshore / epubcheck

Automatically exported from code.google.com/p/epubcheck

MIT License

0 stars 0 forks source link

Remote audio/video resources flagged as invalid #202

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

Epubcheck reports remote resource references in source elements as being 
required in the container. Tweaking the cc-shared-culture example to the 
following:

<video id="video1" controls="controls">
    <source src="http://example.com/video/shared-culture.mp4" type="video/mp4"/>
    <source src="http://example.com/video/shared-culture.webm" type="video/webm"/>
</video>

Generates these messages validating:

ERROR: cc-shared-culture.epub/EPUB/xhtml/p10.xhtml(29,97): 
'http://example.com/video/shared-culture.mp4': remote resource reference not 
allowed; resource must be placed in the OCF

ERROR: cc-shared-culture.epub/EPUB/xhtml/p10.xhtml(30,99): 
'http://example.com/video/shared-culture.webm': remote resource reference not 
allowed; resource must be placed in the OCF

Original issue reported on code.google.com by mgarrish on 24 Aug 2012 at 1:15

GoogleCodeExporter commented 8 years ago

Not sure, but on a minor note "resource must be included in the EPUB container" 
might be a little more user-friendly message here, too. OCF is kinda TLA-y.

Original comment by mgarrish on 24 Aug 2012 at 1:23

GoogleCodeExporter commented 8 years ago

I found the actual error here. In updating the EPUB, I didn't add manifest 
entries for the remote resources.

It would be better if the error indicated a missing manifest entry, as it sends 
you off on the wrong track to try and debug.

Original comment by mgarrish on 28 Aug 2012 at 1:03

GoogleCodeExporter commented 8 years ago

Original comment by markus.g...@gmail.com on 1 Oct 2012 at 8:31

Changed state: Accepted
Added labels: Milestone-3.0.0

GoogleCodeExporter commented 8 years ago

Original comment by markus.g...@gmail.com on 15 Oct 2012 at 8:20

GoogleCodeExporter commented 8 years ago

This issue was closed by revision r357.

Original comment by rdeltour@gmail.com on 16 Oct 2012 at 1:36

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

Thanks, this mostly works as expected now.

Unfortunately, it tests the name of the current element to determine whether to 
avoid the remote reference error, which means if the remote audio/video is 
listed in a child source element the more confusing error still gets generated.

It does work when only a single @src is listed on the audio/video.

Original comment by mgarrish on 27 Oct 2012 at 9:30

GoogleCodeExporter commented 8 years ago

Good catch. I'm reopening...

Original comment by rdeltour@gmail.com on 28 Oct 2012 at 9:42

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

Should this fix be expanded to include secure https:// remote-resource 
references as well as external audio and/or video hosted media player generated 
links? Allowing these references could eliminate some obvious security issues. 
Yes?

Original comment by CindyMar...@gmail.com on 25 Nov 2012 at 11:57

GoogleCodeExporter commented 8 years ago

This issue was closed by revision r384.

Original comment by rdeltour@gmail.com on 29 Nov 2012 at 10:16

Changed state: Fixed