jacyzon / in_hand_scanner

In hand scanner from PCL 1.8.0 with enhanced depth filter
7 stars 4 forks source link

Error while compiling -- virtual pcl::OpenNIGrabberCustom #1

Open saimanoj18 opened 6 years ago

saimanoj18 commented 6 years ago

Hi,

Thank you for making your work open source.

When I am trying to compile it, I got this error. Could you help me solve it ?

sai@X250:~/sai_workspace/pcl_workspace/in_hand_scanner-master$ make [ 3%] Building CXX object CMakeFiles/pcl_apps_in_hand_scanner.dir/src/in_hand_scanner.cpp.o In file included from /home/sai/sai_workspace/pcl_workspace/in_hand_scanner-master/src/in_hand_scanner.cpp:63:0: /home/sai/sai_workspace/pcl_workspace/in_hand_scanner-master/include/pcl/apps/in_hand_scanner/openni_grabber_custom.h:13:5: error: looser throw specifier for ‘virtual pcl::OpenNIGrabberCustom::~OpenNIGrabberCustom()’ ~OpenNIGrabberCustom() { } ^ In file included from /home/sai/sai_workspace/pcl_workspace/in_hand_scanner-master/src/in_hand_scanner.cpp:54:0: /usr/local/include/pcl-1.8/pcl/io/openni_grabber.h:111:15: error: overriding ‘virtual pcl::OpenNIGrabber::~OpenNIGrabber() throw ()’ virtual ~OpenNIGrabber () throw (); ^ CMakeFiles/pcl_apps_in_hand_scanner.dir/build.make:186: recipe for target 'CMakeFiles/pcl_apps_in_hand_scanner.dir/src/in_hand_scanner.cpp.o' failed make[2]: [CMakeFiles/pcl_apps_in_hand_scanner.dir/src/in_hand_scanner.cpp.o] Error 1 CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/pcl_apps_in_hand_scanner.dir/all' failed make[1]: [CMakeFiles/pcl_apps_in_hand_scanner.dir/all] Error 2 Makefile:83: recipe for target 'all' failed make: *** [all] Error 2 sai@X250:~/sai_workspace/pcl_workspace/in_hand_scanner-master$

Thank you very much!

jacyzon commented 6 years ago

Hi, I could compile on my environment without error however I noticed that the parent class of OpenNIGrabberCustom declares destructor that no exceptions can be thrown.

Please try the tip version https://github.com/jacyzon/in_hand_scanner/commit/4b0aa6c6cc4c94f673784580f1be6f0a8bfad136, thanks.