Closed spolcyn closed 2 months ago
@jadchaar This feature has been manually tested -- would love a quick sanity check that this feature is reasonable to add and that I didn't miss it somewhere. Then will add automated tests.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
4e5d100
) to head (b9aa251
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have applied the suggestions and added a test. Let me know if there are any outstanding issues!
@jadchaar Any further issues or clarifications with this PR?
Thanks again for the contribution @spolcyn. LGTM!
This improves download efficiency when some filings have been already downloaded to another location, such as when doing incremental updates.
The existing logic to skip already downloaded files when they are in the same
download_folder
is useful for local-only use, but is less useful when files are only local for a brief period before being sent to long-term storage.