Closed alexbilbie closed 11 years ago
The streaming addition is okay, as long as you make the additions requested in #90.
A few comments about the rest of it:
fopen/fread/fclose
here. file_get_contents
is basically a wrapper for doing exactly that.$response === false
and manually throw the exception. If making a specific connection check in the transport layer is desired, it should also be done for the Transport\Curl connector.Will you please revert the fread and the exception throwing changes, and make a separate pull request?
Have opened #99 with aforementioned changes
Fixes #92