search

jadenquinn / ivyroundup

Automatically exported from code.google.com/p/ivyroundup
0 stars 0 forks source link

sqljet 1.1.6 is broken #404

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
- The zip file no longer exists, so you can't build this resource.
- Even if you could, the dependency on antlr rather than antlr-runtime is wrong.

I put this in originally so it's my fault :)

Attached diff switches to using the maven repo to get the files. However, the 
sqljet-browser is a different maven resource so I've dropped support for this.

I should probably add sqljet-browser as a separate item in the repo.

Original issue reported on code.google.com by steven.n...@gmail.com on 25 Apr 2013 at 11:05

GoogleCodeExporter commented 8 years ago 
patch does not apply cleanly

Original comment by spatialguru.net@gmail.com on 25 Apr 2013 at 2:43

GoogleCodeExporter commented 8 years ago 
Actually the patch looks like it was generated incorrectly. E.g., it contains 
"GENERATED FILE - DO NOT EDIT", which implies a diff from src/modules to 
repo/modules.

Instead, follow instructions here:

    https://code.google.com/p/ivyroundup/wiki/ModuleMaintainerGuidelines#Adding_new_revisions

Original comment by archie.c...@gmail.com on 25 Apr 2013 at 3:02

GoogleCodeExporter commented 8 years ago 
My bad.

Original comment by steven.n...@gmail.com on 25 Apr 2013 at 3:09

GoogleCodeExporter commented 8 years ago 
I don't know what came over me. I've done a load of these perfectly correctly 
then decided to just send in a duff patch. Hey ho. Anyway, here's a better 
patch :)

Original comment by steven.n...@gmail.com on 25 Apr 2013 at 3:34

Attachments:

GoogleCodeExporter commented 8 years ago 
Also, this is issue 404. I should've just not attached the patch so someone 
could put a "404 Patch not found" comment. Missed opportunity....

Original comment by steven.n...@gmail.com on 25 Apr 2013 at 3:35

GoogleCodeExporter commented 8 years ago 
Thanks, much better :)

Fixed in r2660.

Original comment by archie.c...@gmail.com on 25 Apr 2013 at 3:40

GoogleCodeExporter commented 8 years ago

Original comment by archie.c...@gmail.com on 25 Apr 2013 at 3:40