search

jadijadi / bestoon

یک پروژه برای دیدن اینکه چطوری یک ایده می تونه به مرحله اجرا برسه. قدم به قدم فیلم گرفتم و منتشر کردم و خود سیستم هم برای عموم قابل استفاده است
http://bestoon.ir
827 stars 178 forks source link

Vazir Font in Sass #24

Closed jaavid closed 7 years ago

jaavid commented 7 years ago

set up sass for ionic add Vazir font in ionic sass files override ionic sass variable to use vazir font

ShalbafZadeh commented 7 years ago

@jaavid is there any duplication between this pull request and https://github.com/jadijadi/bestoon/pull/23 ? i think one this pull requests could be merged cc:@bobsilon

bobsilon commented 7 years ago

@ShalbafZadeh Yes both the same I think, The only difference is their method of implementation. @jaavid uses ionic setup sass. And the other uses gulpjs to create styles based on scss files. One should be merged.

jadijadi commented 7 years ago

@ShalbafZadeh @jaavid @bobsilon thanks all for discussing the issue. I'll go with ionic setup sass solution.