search

jadijadi / bestoon

یک پروژه برای دیدن اینکه چطوری یک ایده می تونه به مرحله اجرا برسه. قدم به قدم فیلم گرفتم و منتشر کردم و خود سیستم هم برای عموم قابل استفاده است
http://bestoon.ir
827 stars 178 forks source link

Add .gitattributes #33

Closed ShalbafZadeh closed 7 years ago

ShalbafZadeh commented 7 years ago

now Github detects bestoon as a python project instead of a js project

Github is using linguist for detecting language of repositories and it's behavior can be overridden

This pull request overrides it and counts all js files as python files

mamal72 commented 7 years ago

@ShalbafZadeh I think it's not our best option. The JS files are JavaScript files! There are other type of files (like SCSS) too. It's not good to force all of them to be python language file.

There are several other options:

  1. Let it be as is and ignore this issue! 😁
  2. Separate clients from the main Django app. They can all have their own repositories.
  3. Use the following attribute in our .gitattributes in order to exclude clients directory from Linguist as most of JS and SCSS files are in clients directory. 
    clients/* linguist-vendored

    I think the second aproach is the best but the third is well too.

What's your opinion?

ShalbafZadeh commented 7 years ago

@mamal72 I think third one is better approach bestoon is a project for getting started with web developing and separating part of project will confuse people ( at least in current state of project 😃) i think @jadijadi should decide here

jadijadi commented 7 years ago

lets decide later. this will make confusion at the moment. thanks to both of you