some bugs fixed and some features added (listed in the comment)

jadijadi / riverraidrust

A text based river raid clone in Rust; streamed

GNU General Public License v3.0

94 stars 28 forks source link

some bugs fixed and some features added (listed in the comment) #14

Closed shayan15sa closed 7 months ago

shayan15sa commented 7 months ago

Hi jadi, special thanks for making this project. I've learned many new things so far. Added features:

~~Now every bullet can destroy just one enemy~~
Bullets destroy when hitting the ground
A beep sound for shooting (Beep sound should be on in your terminal emulator)
After enemies are hit they become a dead body and will be shown as "x" for one frame Fixed bugs:
the good bye message is now shown exactly in the middle of the screen

Again, thank you very much for anything you have taught me ❤️ shayan

panoschagias commented 7 months ago

I think the fact that "bullets" can hit more than one enemy is an intended feature. That's the reason why their original shape was changed, to indicate their power.

shayan15sa commented 7 months ago

Oh, sorry I didn't know that. So I'm gonna change the code and remove that part. Thank for letting me know.

jadijadi commented 7 months ago

Thanks @shayan15sa Highly appreciated. I had a lot of changes on the code. Can you please rebase based on the new code and:

remove the beep. lets keep the game silent
remove the good bye message, we have a new fancy one and I really loved the 'x' idea for dead enemies.

Sorry for the trouble. will merge sooner next time.

shayan15sa commented 7 months ago

Sure thing. I'll do it as fast as I can. Thank you very much for your attention.

shayan15sa commented 7 months ago

i moved this PR here