search

jadijadi / riverraidrust

A text based river raid clone in Rust; streamed
GNU General Public License v3.0
94 stars 28 forks source link

split project to different crates #34

Closed tt-abdulhaq closed 7 months ago

tt-abdulhaq commented 7 months ago

I just split the project to different crates. add b key code for champing I hope review this.

tt-abdulhaq commented 7 months ago

This looks very clean , couldn't drawing also get split into another crate ?

we can put drawing to another module also, but I thing drawing is functionality of world. we can add draw as a method of world also. please give me your suggestion.

ghost commented 7 months ago

This looks very clean , couldn't drawing also get split into another crate ?

we can put drawing to another module also, but I thing drawing is functionality of world. we can add draw as a method of world also. please give me your suggestion.

Actually I'm new to Rust but I'll provide you my opinion (it's better to fulfill more research and do Q&A) but I think it will be more readable to keep drawing at a different module so you can also open an issue and ask about this implementation.

jadijadi commented 7 months ago

Thank you very much @tt-abdulhaq . This is great. But.. the issue is code has changed a lot. Is it possible for you to redo this and send another PR based on the latest code? I would highly appreciated that and will merge that one first not to create this conflicts again. sorry for the hard task :)

Hint.. maybe for others:

tt-abdulhaq commented 7 months ago

Thank you very much @tt-abdulhaq . This is great. But.. the issue is code has changed a lot. Is it possible for you to redo this and send another PR based on the latest code? I would highly appreciated that and will merge that one first not to create this conflicts again. sorry for the hard task :)

Hint.. maybe for others:

  • In this case you have to redo the changes on your computer based on the latest code, and then do a "git push -ff"

Certainly! I'll rework the changes on my end based on the latest code and submit another pull request. I'll make sure to resolve any conflicts that may arise and push the changes with I'll git push -ff for a smooth integration.

tt-abdulhaq commented 7 months ago

please review my PR on riverraidrust https://github.com/jadijadi/riverraidrust/pull/53

On Sat, Mar 16, 2024 at 12:03 PM Jadi @.***> wrote:

Thank you very much @tt-abdulhaq https://github.com/tt-abdulhaq . This is great. But.. the issue is code has changed a lot. Is it possible for you to redo this and send another PR? I would highly appreciated that and will merge that one first not to create this conflicts again. sorry for the hard task :)

— Reply to this email directly, view it on GitHub https://github.com/jadijadi/riverraidrust/pull/34#issuecomment-2001892174, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4PRQFF6E34SXVLHDF2XQSLYYPYTPAVCNFSM6AAAAABESCIYL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBRHA4TEMJXGQ . You are receiving this because you were mentioned.Message ID: @.***>