Closed panoschagias closed 7 months ago
i think doing if/else condition checking for choosing between ascii texts is extra overhead... My suggestion is to choose minimal ASCII art that fits almost any terminal scale, so you don't have to check the terminal size for either just putting ascii text into it or not. (I know you exactly did what @jadijadi asked to do in issues but maybe we can consider a better option) GL.
Kind of agree... but lets merge this one. and we will have smaller ascii arts later.
@jadijadi I don't know if it was intentional or not but this part of the goodbye_screen
function is missing, making the ASCII art appear on the goodbye screen even if there is not enough space. Will do a PR so it is not forgotten.
- let _ = sc.queue(MoveTo(0, 2));
- let _ = sc.queue(Print(goodbye_msg1));
- let _ = sc.queue(MoveTo(0, 10));
- let _ = sc.queue(Print(goodbye_msg2));
+ if world.maxc > 77 {
+ let _ = sc.queue(MoveTo(0, 2));
+ let _ = sc.queue(Print(goodbye_msg1));
+ let _ = sc.queue(MoveTo(0, 10));
+ let _ = sc.queue(Print(goodbye_msg2));
+}
+else {
+ let _ = sc.queue(MoveTo(0, 2));
+ let _ = sc.queue(Print("Good Game!\n\rThanks."));
+}
Closes #37