search

jadjoubran / laravel-ng-artisan-generators

Laravel artisan AngularJS generators
MIT License
90 stars 23 forks source link

Further improvements #46

Closed MatteoMeil closed 6 years ago

MatteoMeil commented 6 years ago

I made some big changes at the code in order to make it more maintainable. I also added two commands:

All functions have been tested and work correctly, but, please, take a look at the code and try it your own to have the certainty it works in the correct way (you can find a bug I didn't notice)

For users, doesn't change anything, the big changes are under the hood.

jadjoubran commented 6 years ago

Thanks a lot for this @MatteoMeil Can you please sync your repo with upstream (jadjoubran/laravel-ng-artisan-generators) first? as I think we've got the changes from the previous PR here Let me know if you want a step by step commands for it Cheers!

MatteoMeil commented 6 years ago

If you can provide step-by-step commands would be great

Matteo Milanese

Il mar 28 ago 2018, 14:30 Jad Joubran notifications@github.com ha scritto:

Thanks a lot for this @MatteoMeil https://github.com/MatteoMeil Can you please sync your repo with upstream (jadjoubran/laravel-ng-artisan-generators) first? as I think we've got the changes from the previous PR here Let me know if you want a step by step commands for it Cheers!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jadjoubran/laravel-ng-artisan-generators/pull/46#issuecomment-416565825, or mute the thread https://github.com/notifications/unsubscribe-auth/AgduJa40PLTw3zogU1gweCtrQqRn6zwfks5uVTfqgaJpZM4WOXGW .

jadjoubran commented 6 years ago

Sure thing! This guide from github should help I'll close this PR in favor of the new one Thanks again for your time!