search

jadjoubran / laravel-ng-artisan-generators

Laravel artisan AngularJS generators
MIT License
90 stars 23 forks source link

Fork synced #47

Closed MatteoMeil closed 5 years ago

MatteoMeil commented 6 years ago

Synced repo in order to complete #46

jadjoubran commented 6 years ago

Thanks for this Matteo! It will take me around a week or two to be able to review it Will let you know soon

MatteoMeil commented 6 years ago

Recently i found a bug in older version of Laravel: i used replaceNamespace() method in commands' constructor but it has been introduced in newer versions so it must be changed with addNamespace() to guarantee compatibility with older versions of Laravel. If you could make these changes before merge would be great

Matteo Milanese

Il ven 14 set 2018, 12:11 Jad Joubran notifications@github.com ha scritto:

Thanks for this Matteo! It will take me around a week or two to be able to review it Will let you know soon

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jadjoubran/laravel-ng-artisan-generators/pull/47#issuecomment-421306630, or mute the thread https://github.com/notifications/unsubscribe-auth/AgduJUeAgCHU1VEKQ1ba2Ey1Mi7IV9l2ks5ua4C-gaJpZM4WZWlc .

MatteoMeil commented 5 years ago

I close this PR in order to open another PR to fix that bug

jadjoubran commented 5 years ago

Thanks 👍