jadjoubran / laravel5-angular-material-starter

Get started with Laravel 5.3 and AngularJS (material)
https://laravel-angular.readme.io/
MIT License
1.66k stars 400 forks source link

docs say to use snake_case but initial pages/components use kebab-case #360

Closed daem0ndev closed 8 years ago

daem0ndev commented 8 years ago

When following the documentation it says to use snake_case when using the generators, but that breaks consistency with the components/pages that come out of the box in the starter, such as forgot-password, register-form, reset-password, etc.

I suggest maybe supporting input of snake_case but have the generator automatically convert to kebab-case for the filesystem to match the out of the box components and pages.

Also, definitely take a look at a project I contribute to called ng6-cli which could be used and wrapped by the generators in your package. It handles alot of the same things you're trying to do, but even goes a step farther in how it updates all of your file references.

jadjoubran commented 8 years ago

Hi @daem0ndev Thanks for this!

Indeed, I'll fix the documentation to mention that they should be kebab-case However there's no need restricting people to use kebab case if they prefer snake_case

ng6-cli seems very cool! Would you be able to point out some of the stuff that are missing but you might find useful for this starter? Although for the release after 3.3, we'll be using the official ng-cli for sure (for angular 2)

jadjoubran commented 8 years ago

Fixed the docs, thanks!

daem0ndev commented 8 years ago

The examples still show like user_profile instead of user-profile :)

jadjoubran commented 8 years ago

@daem0ndev Thanks 😄 fixed!