search

jadjoubran / laravel5-angular-material-starter

Get started with Laravel 5.3 and AngularJS (material)
https://laravel-angular.readme.io/
MIT License
1.66k stars 400 forks source link

StyleCI Turned Off? #395

Closed GrahamCampbell closed 8 years ago

jadjoubran commented 8 years ago

I wanted to ping you about it but forgot 😄 I had to temporarily turn it off because it was removing unused imports which are kept on purpose in Laravel to make it easier in some files I used to have the present: laravel what other changes should I make? Thanks!

GrahamCampbell commented 8 years ago

The laravel/laravel repo just turns off the unused imports fixer.

GrahamCampbell commented 8 years ago 
preset: laravel

disabled:
  - unused_use
jadjoubran commented 8 years ago

Great thanks! I've also got this issue: https://styleci.io/analyses/qoLBQb any idea?

GrahamCampbell commented 8 years ago

Looks ok to apply the changes. laravel/laravel excludes those files. I'll probably talk to Taylor about getting those defaults changes at somepoint.

GrahamCampbell commented 8 years ago

Alternatively, just remove those comments. That's probably what I'll recommend for the core.

jadjoubran commented 8 years ago

Okay, thanks @GrahamCampbell