jadjoubran / laravel5-angular-material-starter

Get started with Laravel 5.3 and AngularJS (material)
https://laravel-angular.readme.io/
MIT License
1.66k stars 400 forks source link

No seeJsonKeyValueString() function #399

Closed monkeyWzr closed 8 years ago

monkeyWzr commented 8 years ago

Hi, I'm a new learner. When I was trying the tutorial using the master branch, I found there's no seeJsonKeyValueString() in TestCase class (no seeJsonKeyValue() either). So phpunit can't run successfully as the video shows. I wonder if it is because this function is deprecated and the tutorial should be updated:D.

jadjoubran commented 8 years ago

Hi @monkeyWzr Thanks for reporting this Yes indeed, those functions have been deprecated. Just to make sure, are you watching the tutorial in the screencast? or going through the text documentation?

monkeyWzr commented 8 years ago

The text documentation TDD(v3.3). And I think the same codes shows up in the screencast, too.(at about 3:50 in the video Laravel Angular Material Starter #3 - Tutorial)

Banjerr commented 8 years ago

I also just ran across this, watching the screen cast. Whats the alternative function to use here? @jadjoubran thanks!

edit figured it out through some trial and error. ->seeJson(['name' => $post->name, 'topic' => $post->topic]) instead of ->seeJsonKeyValueString('name', $post->name) ->seeJsonKeyValueString('topic', $post->topic);

jadjoubran commented 8 years ago

Yes true, the reason why those helpers were deprecated was that Laravel started providing the seeJson helper I will update the docs & tutorial soon Thanks!

yazfield commented 8 years ago

@jadjoubran suggested an edit to the docs. Just add a YouTube annotation to the videos :)

jadjoubran commented 8 years ago

@yazfield on it, thanks 😄 I was off the grid for the past month (small surgery, conferences & overloaded with work) Will try to release 3.4 tonight

jadjoubran commented 8 years ago

Fixed in both places!

yazfield commented 8 years ago

@jadjoubran oh I hope you're doing well!

jadjoubran commented 8 years ago

@yazfield yep I fully recovered, cheers!