search

jadjoubran / laravel5-angular-material-starter

Get started with Laravel 5.3 and AngularJS (material)
https://laravel-angular.readme.io/
MIT License
1.66k stars 400 forks source link

fix #421 #423

Closed nueko closed 7 years ago

nueko commented 7 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change?

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

nueko commented 7 years ago

this is not fixed yet as there's such snippet on Controller.php

jadjoubran commented 7 years ago

Thanks @nueko for this! Actually why not keep it as wantsJson() only? Do you see any downside with this?

nueko commented 7 years ago

I tested it with make:auth scaffolding as it use ThrottlesLogin and it uses web middleware, but, I think we better use expectsJson for that,

jadjoubran commented 7 years ago

Okay, thanks for this @nueko I'll pull the branch and run some quick tests and get back to you Thanks! 😄

jadjoubran commented 7 years ago

Looks great, thanks!