jadjoubran / webdash

🔥 Orchestrate your web project with Webdash the customizable web dashboard
https://webdash.xyz
MIT License
1.55k stars 70 forks source link

Not working with MeteorJS #53

Closed rolljee closed 6 years ago

rolljee commented 6 years ago

Hello, currently working on a project using MeteorJS

Step to reproduce

meteor npm install --save-dev webdash-package-json webdash-npm-scripts webdash-performance-budget webdash-pwa-manifest

npx webdash serve

Output

screen shot 2018-03-29 at 15 58 08

In the project

screen shot 2018-03-29 at 16 03 25

Bug? Or I am doing something wrong?

jadjoubran commented 6 years ago

Thanks for giving webdash a try @rolljee! Can you please paste here the entires of webdash and webdash- plugins in your package.json Also are they in dependencies or devDependencies? Also what does meteor npm install do differently than simply running npm install? (I never used meteor)

jasonk commented 6 years ago

All that meteor npm install really does is to make sure that you run the version of npm that is bundled with meteor rather than the system one.

All that you have to do to make this work is use meteor npx too..

meteor npm install --save-dev webdash-package-json webdash-npm-scripts webdash-performance-budget webdash-pwa-manifest

meteor npx webdash serve
jadjoubran commented 6 years ago

Did you run meteor npm install --save-dev webdash? And can you show me your package.json's devDependencies (where webdash & its plugins show up)?

rolljee commented 6 years ago

Hello Again! I've made some tests working against Meteor

@jasonk I've tried all these things... neither wrapped or not wrapped with Meteor, the output is the same

@jadjoubran Yes all of them are in the devDepedencies

Other thing, all plugins installed are making meteor to crash and cannot restart with this output

screen shot 2018-03-30 at 12 13 18

jadjoubran commented 6 years ago

it's not clear what's "not working" What command are you running? The screenshot doesn't seep to be npx webdash serve (or meteor npx webdash serve)

Please give us more context to be able to help

rolljee commented 6 years ago

screen shot 2018-03-30 at 17 32 56

Here is a screenshot of the step to reproduce.

I've made a sample repo to let you test : https://github.com/rolljee/meteor-webdash

jadjoubran commented 6 years ago

Thanks for setting up a sample repo! 😄 I couldn't setup meteor successfully yesterday, the installer kept on failing I'll give it another try today

rolljee commented 6 years ago

Just some steps if you are not familiar with meteor :)

  1. curl https://install.meteor.com/ | sh
  2. cd into the cloned repo
  3. run meteor npm install ( install all from package.json )
  4. you can then follow steps on the last screenshot 👍

using meteor create command automatically install all dependencies, but when you clone you have to manually do it yourself !

jadjoubran commented 6 years ago

Okay I was able to set it up

  1. Your package.json (in the example repo) is missing webdash from the devDependencies.. you need to install it with meteor npm install --save-dev webdash (this is different than the plugins, this is webdash core)
screen shot 2018-03-31 at 2 16 07 pm
  1. I was able to make it work screen shot 2018-03-31 at 2 16 26 pm
screen shot 2018-03-31 at 2 16 40 pm

Can you please clone the sample repo, and run meteor npm install --save-dev webdash and then run meteor npx webdash serve and let me know if it works

rolljee commented 6 years ago

As simple as that, thank you for your time ! Great work ! It's perfectly working on chrome !

screen shot 2018-03-31 at 19 35 34

however it is acting weird on safari, see the capture below

screen shot 2018-03-31 at 19 37 40

  1. Display is overlapping
  2. Package.json plugin are not loaded

When I first log to the page I can see the package.json plugin loading and display something, but then 1 sec later it goes away.

Safari web console show this

screen shot 2018-03-31 at 19 41 41

Witch is leading to this piece of code

screen shot 2018-03-31 at 19 42 26

If you want me to close this issue since the issue is answered and you want me to open an other issue ??

Again, thx again for your time.

jadjoubran commented 6 years ago

Awesome, I'm glad that it works!

That's because Safari doesn't support merging objects using the spread operator ... It's working for me on Safari Technology Preview, can you please try updating Safari to the latest? (there was an update just yesterday) and let me know if it works or not Thanks!

rolljee commented 6 years ago

It work with technology Preview 👍