search

jadjoubran / webdash

🔥 Orchestrate your web project with Webdash the customizable web dashboard
https://webdash.xyz
MIT License
1.55k stars 70 forks source link

Getting set up: Object.entries is not a function #67

Closed 1j01 closed 6 years ago

1j01 commented 6 years ago 
+ webdash@1.2.0
added 67 packages from 58 contributors and updated 1 package in 103.9s
$ npx webdash
Object.values is not a function
$ npx webdash serve
Object.entries is not a function
jadjoubran commented 6 years ago

Thanks for trying webdash!

I think you're running a version of node that is older that 8.0 Can you please update node and try again?

1j01 commented 6 years ago

Oh, that makes sense. I just saw those one line errors (no stack trace) and noped out of debugging. (I had already done a lot of debugging that day, and I was specifically switching projects to do something that was not debugging.)

1j01 commented 6 years ago

Theoretically there would have been a warning about engines not matching, but I guess I missed that. It would be nice if it checked the version of Node from within the code. Or if it was mentioned on the docs what version of Node you need. Oh wait, it does mention it. I definitely missed that. (a git blame confirms it was added before I looked at it.) It would be nice if it was highlighted as a real step, something you need to check. (I'm pretty sure I pasted in that whole thing after a quick glance of it 😳)

jadjoubran commented 6 years ago

I'm not sure if engines made it to the last release or not, but it'll be available in 1.3 but anyway it's just a warning on installation, I feel like people tend to skip these warnings so in v1.3 there'll be a warning when you run webdash serve, as shown here

38050840-0be84728-32d5-11e8-8566-813925d19414

reference: #46

1j01 commented 6 years ago

Sweet!