search

jadkins89 / Recipe-Scraper

A JS package for scraping recipes from the web.
https://www.npmjs.com/package/recipe-scraper
MIT License
97 stars 52 forks source link

Merge Conflicts Fix #38

Closed cdthomp1 closed 3 years ago

jadkins89 commented 3 years ago

Hey @cdthomp1,

Thanks for your contribution, I should have some time tomorrow to look this over. Stay tuned.

jadkins89 commented 3 years ago

Hey @cdthomp1,

Sorry to move the goal post on you here but I just refactored the package to now use a more OOP approach which will remove a lot of the duplicate logic that previously existed. Could you refactor this new scrape to conform to this new pattern?

Could you also have the scrape grab the servings and time data as well? It looks like that website is using a wordpress plugin for the recipe similar to the existing scrape for melskitchencafe.com. Looking at that scrape may help speed up which selectors to use.

cdthomp1 commented 3 years ago

@jadkins89 Sure thing, I will work on that for this website.

Thanks!

cdthomp1 commented 3 years ago

Closing this PR, will open a new, clean PR with the changes