search

jadolg / outline-vpn-api

A Python API wrapper for Outline VPN https://getoutline.org/
MIT License
114 stars 30 forks source link

Adding Timeout #2

Open Wachu985 opened 1 year ago

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Wachu985 commented 1 year ago

I propose to add timeout to the methods to give the user more control of the timeout

Wachu985 commented 1 year ago

Yea it's a perfect idea

Hi @Wachu985 thank you so much for your contribution. I'd like to change a couple of details though. I'd like to have the default set to None instead of 60 since it's requests default value and tu use it as a named parameter on the calls because it's better to read and maintain.