Smooth PWM Output - Githubissues

vaishnavachath commented 6 years ago

I have tried to fix these issues related to PWM,

spikes occuring while writing zero duty cycle(proposed soln: disabled pwm while writing zero duty/freq)
smooth pwm output while sweping pwm frequency(proposed soln: suggested implementation alongside current implementation)
digitalWrite() on ANALOG_OUTPUT(proposed soln: write duty cycle according to value(0/1))

https://github.com/beagleboard/bonescript/issues/26 https://github.com/beagleboard/bonescript/issues/30 https://github.com/beagleboard/bonescript/issues/17

I have uploaded the test video here : https://youtu.be/_CiSsroef18

I couldn't figure out how to write test cases for these patches , that was why i included some non relevant tests,please excuse.

coveralls commented 6 years ago

Coverage increased (+0.06%) to 37.111% when pulling e5b648932e6db2fb03f2455706524972ee42f5ae on vaishnav98:master into 61d2fa26a8e93449fec01f8693d734878cf1077f on jadonk:master.

vaishnavachath commented 6 years ago

Glad to hear that :) , sure I will try to figure out a solution to the issue of removing sync read/write operations in future (didn't do it now for the patch since we need to make consistent changes everywhere).

jadonk / bonescript

Smooth PWM Output #171